Fix issue where percentages were off of the border box, not padding box #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D51330526 |
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
|
This pull request was exported from Phabricator. Differential Revision: D51330526 |
joevilches
force-pushed
the
export-D51330526
branch
from
084bfce
to
b28baeb
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 4, 2023
…ox (facebook#1485) Summary: Pull Request resolved: facebook#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526 fbshipit-source-id: 057303cc035435b9f28c51c5d36f963c55b40170
joevilches
force-pushed
the
export-D51330526
branch
from
b28baeb
to
8d926d8
Compare
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
…ox (facebook#1485) Summary: X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
…ox (facebook#1485) Summary: X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
|
This pull request was exported from Phabricator. Differential Revision: D51330526 |
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
…ox (facebook#1485) Summary: X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
…ox (facebook#1485) Summary: Pull Request resolved: facebook#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Differential Revision: https://www.internalfb.com/diff/D51330526?entry_point=27 fbshipit-source-id: 3e4a7e4d74bf6c286cf3281430e2412dffcdc9e9
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
…ox (facebook#1485) Summary: Pull Request resolved: facebook#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Differential Revision: https://www.internalfb.com/diff/D51330526?entry_point=27 fbshipit-source-id: 891758632b33e88c176fa5b4023c3495849119f7
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
…ox (facebook#1485) Summary: Pull Request resolved: facebook#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Differential Revision: https://www.internalfb.com/diff/D51330526?entry_point=27 fbshipit-source-id: ed9947294bb1ae9f656a7f1fd0f5a1a121819674
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 Pull Request resolved: facebook#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Differential Revision: https://www.internalfb.com/diff/D51330526?entry_point=27 fbshipit-source-id: fc595cd3f2d525e32b6ccea80d3c99b582d7b922
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
…ox (facebook#1485) Summary: Pull Request resolved: facebook#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Differential Revision: https://www.internalfb.com/diff/D51330526?entry_point=27 fbshipit-source-id: ed2ed75f300b9c9117e731a139889ad0c68cf00d
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
…ox (facebook#1485) Summary: Pull Request resolved: facebook#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Differential Revision: https://www.internalfb.com/diff/D51330526?entry_point=27 fbshipit-source-id: 0421532ab478fc73ff10a5311d729c4036136140
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
…ox (facebook#1485) Summary: Pull Request resolved: facebook#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Differential Revision: https://www.internalfb.com/diff/D51330526?entry_point=27 fbshipit-source-id: ccf035ffd6ed9e785014e3820139fce21e444149
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
…ox (facebook#1485) Summary: Pull Request resolved: facebook#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Differential Revision: https://www.internalfb.com/diff/D51330526?entry_point=27 fbshipit-source-id: 02b2921576666940ab11f858cae8c2db44a0acc0
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
…ox (facebook#1485) Summary: Pull Request resolved: facebook#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Differential Revision: https://www.internalfb.com/diff/D51330526?entry_point=27 fbshipit-source-id: 42df6388386359998fffd34c0920468d84856179
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
…ox (facebook#1485) Summary: Pull Request resolved: facebook#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Differential Revision: https://www.internalfb.com/diff/D51330526?entry_point=27 fbshipit-source-id: 155984648052313d9deb0ef8b69e41bd813a82ba
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
…ox (facebook#1485) Summary: Pull Request resolved: facebook#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Differential Revision: https://www.internalfb.com/diff/D51330526?entry_point=27 fbshipit-source-id: 22006bc7c342cfd4ca3355e101b67f4592838060
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
…ox (facebook#1485) Summary: Pull Request resolved: facebook#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Differential Revision: https://www.internalfb.com/diff/D51330526?entry_point=27 fbshipit-source-id: eb59fcfcdd6ee40674d5286f1f24426283c92e39
…ng absolute node's position (facebook#1481) Summary: X-link: facebook/react-native#41684 Absolute nodes can be laid out by themselves and do not have to care about what is happening to their siblings. Because of this we can make `positionAbsoluteChild` the sole place where we handle this logic. Right now that is scattered around algorithm with many `if (child is absolute)` cases everywhere. This makes implementing position static a lot harder since we are relying on the CB to do all this work, not the parent. With this change the only time we set position for an absolute node and it matter (i.e. not overwritten) is in `positionAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51290723
Summary: X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
…ox (facebook#1485) Summary: X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
force-pushed
the
export-D51330526
branch
from
9b22a6f
to
e74e6bd
Compare
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
|
This pull request was exported from Phabricator. Differential Revision: D51330526 |
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
…ox (facebook#1485) Summary: Pull Request resolved: facebook#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Differential Revision: https://www.internalfb.com/diff/D51330526?entry_point=27 fbshipit-source-id: e193dae4e8de7e91ccc3d490a928b71b41bb550c
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
…ox (facebook#1485) Summary: Pull Request resolved: facebook#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Differential Revision: https://www.internalfb.com/diff/D51330526?entry_point=27 fbshipit-source-id: 12927c4b028776012ebdbcf84c1299aa2a74e7cb
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
…ox (facebook#1485) Summary: Pull Request resolved: facebook#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Differential Revision: https://www.internalfb.com/diff/D51330526?entry_point=27 fbshipit-source-id: 432d878ceecd9ff8dad16a6751a98a2d9b803037
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
…ox (facebook#1485) Summary: Pull Request resolved: facebook#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Differential Revision: https://www.internalfb.com/diff/D51330526?entry_point=27 fbshipit-source-id: d4b9a54594f83f022c48a176d91e42cc6b30c087
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Dec 8, 2023
Summary: X-link: facebook/yoga#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526 fbshipit-source-id: adc448dfb71b54f1bbed0d9d61c5553bda4b106c
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Dec 8, 2023
…ox (#41686) Summary: X-link: facebook/yoga#1485 Pull Request resolved: #41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526 fbshipit-source-id: adc448dfb71b54f1bbed0d9d61c5553bda4b106c
|
This pull request has been merged in 9b87d8b. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…ox (facebook#41686) Summary: X-link: facebook/yoga#1485 Pull Request resolved: facebook#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526 fbshipit-source-id: adc448dfb71b54f1bbed0d9d61c5553bda4b106c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/react-native#41686
The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at
containingNode->getLayout().measuredDimension(Dimension::Width)which is the border box. So we need to subtract the border from this.Added a test that was failing before this change as well
Reviewed By: NickGerleman
Differential Revision: D51330526